gtk-demo/theming: Don’t mislead about raised class
authorDaniel Boles <dboles@src.gnome.org>
Wed, 13 Sep 2017 13:47:40 +0000 (14:47 +0100)
committerDaniel Boles <dboles@src.gnome.org>
Thu, 14 Sep 2017 17:35:18 +0000 (18:35 +0100)
This class is not added by any widgets nor themed by Adwaita/HC.
However, it is presented here as if it does something. It doesn’t.

But we changed the 2 buttons with the .raised class to use symbolic
icons, unlike their ‘unraised’ counterparts, which is unnecessarily
confusing and might make people think .raised affects icons somehow.

So, make them use the same icons in all cases; that way, if .raised is
ever made to do anything, 6 years later, what it does will be clear.

https://bugzilla.gnome.org/show_bug.cgi?id=644248

demos/gtk-demo/theming.ui

index ed25cb0e0cd79bd585ad8d171eb33de277dfde20..8d1e97aaaac842d0395ee850b944c5956bbe39c2 100644 (file)
@@ -55,7 +55,7 @@
             <property name="label" translatable="yes">Raised</property>
             <property name="use_underline">1</property>
             <property name="is_important">1</property>
-            <property name="icon_name">edit-find-symbolic</property>
+            <property name="icon_name">edit-find</property>
             <style>
               <class name="raised"/>
             </style>
@@ -70,7 +70,7 @@
             <property name="label" translatable="yes">Raised Active</property>
             <property name="use_underline">1</property>
             <property name="is_important">1</property>
-            <property name="icon_name">edit-find-symbolic</property>
+            <property name="icon_name">edit-find</property>
             <property name="active">1</property>
             <style>
               <class name="raised"/>